Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 11 Apr 2024 18:31:58 +0800 | Subject | Re: [PATCH RFC 1/2] clk: hisilicon: rename hi3519 PLL registration function | From | Yang Xiwen <> |
| |
On 4/11/2024 3:53 PM, Stephen Boyd wrote: > Quoting Yang Xiwen (2024-04-11 00:44:33) >> On 4/11/2024 2:52 PM, Stephen Boyd wrote: >>> Quoting Yang Xiwen via B4 Relay (2024-02-24 08:56:09) >>>> diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c >>>> index ff4ca0edce06..77fa4203a428 100644 >>>> --- a/drivers/clk/hisilicon/clk-hi3559a.c >>>> +++ b/drivers/clk/hisilicon/clk-hi3559a.c >>>> @@ -452,7 +452,7 @@ static const struct clk_ops hisi_clk_pll_ops = { >>>> .recalc_rate = clk_pll_recalc_rate, >>>> }; >>>> >>>> -static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, >>>> +static void _hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, >>> Prefix it with hi3559a then to be SoC specific please. But this is also >>> static so I'm not sure why this patch is needed at all. >> >> it includes the header that marks this function non-static. Also the >> prototype is incompatible. > What is 'it'?
The line 18 `#include "clk.h"`, and please see patch 2.
Patch 2 added 2 functions to "clk.h", one of them reused the `hisi_clk_register_pll` name with a different prototype.
> > $ git grep hisi_clk_register_pll > drivers/clk/hisilicon/clk-hi3559a.c:static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, > drivers/clk/hisilicon/clk-hi3559a.c: hisi_clk_register_pll(hi3559av100_pll_clks,
a snippet copied from patch 2:
+int hisi_clk_register_pll(struct device *dev, const struct hisi_pll_clock *clks, + int nums, struct hisi_clock_data *data);
-- Regards, Yang Xiwen
| ![\](/images/icornerr.gif) |