Messages in this thread | | | Subject | Re: [PATCH RFC 1/2] clk: hisilicon: rename hi3519 PLL registration function | From | Stephen Boyd <> | Date | Thu, 11 Apr 2024 00:53:01 -0700 |
| |
Quoting Yang Xiwen (2024-04-11 00:44:33) > On 4/11/2024 2:52 PM, Stephen Boyd wrote: > > Quoting Yang Xiwen via B4 Relay (2024-02-24 08:56:09) > >> diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisilicon/clk-hi3559a.c > >> index ff4ca0edce06..77fa4203a428 100644 > >> --- a/drivers/clk/hisilicon/clk-hi3559a.c > >> +++ b/drivers/clk/hisilicon/clk-hi3559a.c > >> @@ -452,7 +452,7 @@ static const struct clk_ops hisi_clk_pll_ops = { > >> .recalc_rate = clk_pll_recalc_rate, > >> }; > >> > >> -static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, > >> +static void _hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, > > Prefix it with hi3559a then to be SoC specific please. But this is also > > static so I'm not sure why this patch is needed at all. > > > it includes the header that marks this function non-static. Also the > prototype is incompatible.
What is 'it'?
$ git grep hisi_clk_register_pll drivers/clk/hisilicon/clk-hi3559a.c:static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clks, drivers/clk/hisilicon/clk-hi3559a.c: hisi_clk_register_pll(hi3559av100_pll_clks,
| |