Messages in this thread | ![/](/images/icornerl.gif) | | From | Geert Uytterhoeven <> | Date | Thu, 11 Apr 2024 09:45:27 +0200 | Subject | Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC |
| |
Hi Romain,
On Wed, Apr 10, 2024 at 2:24 PM Romain Gantois <romain.gantois@bootlin.com> wrote: > On Tue, 9 Apr 2024, Geert Uytterhoeven wrote: > > > +config DWMAC_RZN1 > > > + tristate "Renesas RZ/N1 dwmac support" > > > + default ARCH_RZN1 > > > > Why default to enabled? > > > > > + depends on OF && (ARCH_RZN1 || COMPILE_TEST) > > The kernel doc states this as one of the possible cases where setting default > y/m makes sense: > > ``` > Sub-driver behavior or similar options for a driver that is “default n”. This > allows you to provide sane defaults. > ``` > > In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default n", and > I think it makes sense to enable the RZN1 ethernet controller driver if both the > stmmac driver and the RZN1 architecture were explicitely selected.
Thanks for your answer, that makes perfect sense!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| ![\](/images/icornerr.gif) |