lkml.org 
[lkml]   [2024]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC
Hi Geert,

On Tue, 9 Apr 2024, Geert Uytterhoeven wrote:

> > +config DWMAC_RZN1
> > + tristate "Renesas RZ/N1 dwmac support"
> > + default ARCH_RZN1
>
> Why default to enabled?
>
> > + depends on OF && (ARCH_RZN1 || COMPILE_TEST)

The kernel doc states this as one of the possible cases where setting default
y/m makes sense:

```
Sub-driver behavior or similar options for a driver that is “default n”. This
allows you to provide sane defaults.
```

In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default n", and
I think it makes sense to enable the RZN1 ethernet controller driver if both the
stmmac driver and the RZN1 architecture were explicitely selected.

Best Regards,

--
Romain Gantois, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
\
 
 \ /
  Last update: 2024-05-27 16:32    [W:0.089 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site