Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 9 Jan 2024 06:29:28 -0800 | From | Breno Leitao <> | Subject | Re: [PATCH net-next 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 |
| |
On Tue, Jan 09, 2024 at 12:25:14PM +0100, Geert Uytterhoeven wrote: > Hi Breno, > > On Mon, Jan 8, 2024 at 7:17 PM Breno Leitao <leitao@debian.org> wrote: > > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > > Add descriptions to all the good old 8390 modules and drivers. > > > > Signed-off-by: Breno Leitao <leitao@debian.org> > > Thanks for your patch! > > > --- a/drivers/net/ethernet/8390/apne.c > > +++ b/drivers/net/ethernet/8390/apne.c > > @@ -610,4 +610,5 @@ static int init_pcmcia(void) > > return 1; > > } > > > > +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver"); > > I would write: > > National Semiconductor 8390 Amiga PCMCIA ethernet driver > > as this driver does not work on generic platforms with a PCMCIA slot.
Thanks. I will update and send a v2.
| ![\](/images/icornerr.gif) |