Messages in this thread | ![/](/images/icornerl.gif) | | From | Geert Uytterhoeven <> | Date | Tue, 9 Jan 2024 12:25:14 +0100 | Subject | Re: [PATCH net-next 01/10] net: fill in MODULE_DESCRIPTION()s for 8390 |
| |
Hi Breno,
On Mon, Jan 8, 2024 at 7:17 PM Breno Leitao <leitao@debian.org> wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to all the good old 8390 modules and drivers. > > Signed-off-by: Breno Leitao <leitao@debian.org>
Thanks for your patch!
> --- a/drivers/net/ethernet/8390/apne.c > +++ b/drivers/net/ethernet/8390/apne.c > @@ -610,4 +610,5 @@ static int init_pcmcia(void) > return 1; > } > > +MODULE_DESCRIPTION("National Semiconductor 8390 PCMCIA ethernet driver");
I would write:
National Semiconductor 8390 Amiga PCMCIA ethernet driver
as this driver does not work on generic platforms with a PCMCIA slot.
> MODULE_LICENSE("GPL");
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| ![\](/images/icornerr.gif) |