Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Tiezhu Yang <> | Subject | [PATCH] LoongArch: Fix definition of ftrace_regs_set_instruction_pointer() | Date | Tue, 9 Jan 2024 14:52:01 +0800 |
| |
The current definition of ftrace_regs_set_instruction_pointer() is wrong, obviously, this function is used to set instruction pointer, so it should call instruction_pointer_set() instead of regs_set_return_value().
There is no side effect by now because it is used for kernel livepatching which is not supported, fix it to avoid failure when testing livepatch in the future.
Fixes: 6fbff14a6382 ("LoongArch: ftrace: Abstract DYNAMIC_FTRACE_WITH_ARGS accesses") Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- arch/loongarch/include/asm/ftrace.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/loongarch/include/asm/ftrace.h b/arch/loongarch/include/asm/ftrace.h index a11996eb5892..de891c2c83d4 100644 --- a/arch/loongarch/include/asm/ftrace.h +++ b/arch/loongarch/include/asm/ftrace.h @@ -63,7 +63,7 @@ ftrace_regs_get_instruction_pointer(struct ftrace_regs *fregs) static __always_inline void ftrace_regs_set_instruction_pointer(struct ftrace_regs *fregs, unsigned long ip) { - regs_set_return_value(&fregs->regs, ip); + instruction_pointer_set(&fregs->regs, ip); } #define ftrace_regs_get_argument(fregs, n) \ -- 2.42.0
| ![\](/images/icornerr.gif) |