Messages in this thread | | | Date | Thu, 8 Jun 2023 18:30:27 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables |
| |
On Thu, 01 Jun 2023, Andy Shevchenko wrote:
> On Tue, May 30, 2023 at 05:11:00PM +0200, Henning Schild wrote: > > Am Sat, 27 May 2023 11:54:08 +0300 > > schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>: > > > > > On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > > > The entries do not seem to be stricly needed when the number of > > > > entries is given via the number of LEDs. But adding them is a > > > > safeguard should anyone ever iterate over the tables to their end, > > > > it also gets us in line with other drivers that register > > > > "leds-gpio" tables. > > > > > > Reported-by? > > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > I think we could do > > > > Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > on merge. But i would not want to send the whole series again for that > > one line. > > Since you added it, `b4` will happily take it, I believe no manual work even > needed for that, thank you!
b4 didn't pick this up. Nor the whole-series Ack provided by Hans.
I added both manually.
-- Lee Jones [李琼斯]
| |