Messages in this thread | | | Date | Tue, 30 May 2023 17:11:00 +0200 | From | Henning Schild <> | Subject | Re: [PATCH v4 1/4] leds: simatic-ipc-leds-gpio: add terminating entries to gpio tables |
| |
Am Sat, 27 May 2023 11:54:08 +0300 schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> On Wed, May 24, 2023 at 02:46:25PM +0200, Henning Schild wrote: > > The entries do not seem to be stricly needed when the number of > > entries is given via the number of LEDs. But adding them is a > > safeguard should anyone ever iterate over the tables to their end, > > it also gets us in line with other drivers that register > > "leds-gpio" tables. > > Reported-by? > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
I think we could do
Reported-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
on merge. But i would not want to send the whole series again for that one line.
Thanks! Henning
> > Signed-off-by: Henning Schild <henning.schild@siemens.com> > > --- > > drivers/leds/simple/simatic-ipc-leds-gpio.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.c > > b/drivers/leds/simple/simatic-ipc-leds-gpio.c index > > e8d329b5a68c..1a1cfdad6218 100644 --- > > a/drivers/leds/simple/simatic-ipc-leds-gpio.c +++ > > b/drivers/leds/simple/simatic-ipc-leds-gpio.c @@ -28,6 +28,7 @@ > > static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = > > { GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 51, NULL, 5, > > GPIO_ACTIVE_LOW), GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 56, NULL, > > 6, GPIO_ACTIVE_LOW), GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 59, > > NULL, 7, GPIO_ACTIVE_HIGH), > > + {} /* Terminating entry */ > > }, > > }; > > > > @@ -42,6 +43,7 @@ static struct gpiod_lookup_table > > simatic_ipc_led_gpio_table_227g = { > > GPIO_LOOKUP_IDX("gpio-f7188x-2", 5, NULL, 5, GPIO_ACTIVE_LOW), > > GPIO_LOOKUP_IDX("gpio-f7188x-3", 6, NULL, 6, GPIO_ACTIVE_HIGH), > > GPIO_LOOKUP_IDX("gpio-f7188x-3", 7, NULL, 7, GPIO_ACTIVE_HIGH), > > + {} /* Terminating entry */ > > } > > }; > > > > -- > > 2.39.3 > > >
| |