| Date | Thu, 8 Jun 2023 12:57:58 -0700 | From | Dan Williams <> | Subject | RE: [PATCH v5 06/26] cxl/pci: Refactor component register discovery for reuse |
| |
Terry Bowman wrote: > The endpoint implements component register setup code. Refactor it for > reuse with RCRB, downstream port, and upstream port setup. > > Move PCI specifics from cxl_setup_regs() into cxl_pci_setup_regs(). > > Move cxl_setup_regs() into cxl/core/regs.c and export it. This also > includes supporting static functions cxl_map_registerblock(), > cxl_unmap_register_block() and cxl_probe_regs().
Looks ok to me. I hit some minor conflicts rebasing it on changes proposed earlier, but no other concerns from me.
|