lkml.org 
[lkml]   [2023]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 41/43] ARM: dts: ep93xx: Add I2S and AC97 nodes
From
On 01/06/2023 07:45, Nikita Shubin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
>
> Add the audio interfaces present in EP93xx SoCs.
>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
> ---
> arch/arm/boot/dts/ep93xx.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ep93xx.dtsi b/arch/arm/boot/dts/ep93xx.dtsi
> index 6da556ceaf04..c8028534dda7 100644
> --- a/arch/arm/boot/dts/ep93xx.dtsi
> +++ b/arch/arm/boot/dts/ep93xx.dtsi
> @@ -301,6 +301,17 @@ ide: ide@800a0000 {
> pinctrl-0 = <&ide_default_pins>;
> };
>
> + ac97: ac97@80880000 {
> + compatible = "cirrus,ep9301-ac97";
> + #sound-dai-cells = <0>;
> + reg = <0x80880000 0xac>;
> + interrupt-parent = <&vic0>;
> + interrupts = <6>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&ac97_default_pins>;
> + status = "disabled";

Squash it. There are no i2s nodes here, so your description is not
accurate and new DTSI should be one patch. You can release early,
release often, but then these would be separate submissions.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-06-01 10:34    [W:0.969 / U:1.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site