lkml.org 
[lkml]   [2023]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 29/43] rtc: m48t86: add DT support for m48t86
    On Mon, Apr 24, 2023, at 14:34, Nikita Shubin wrote:
    > - get regs from device tree
    >
    > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>

    Acked-by: Arnd Bergmann <arnd@arndb.de>

    >
    > +#ifdef CONFIG_OF
    > +static const struct of_device_id m48t86_rtc_of_ids[] = {
    > + { .compatible = "dallas,rtc-m48t86" },
    > + { /* end of table */ },
    > +};
    > +MODULE_DEVICE_TABLE(of, m48t86_rtc_of_ids);
    > +#endif
    > +
    > static struct platform_driver m48t86_rtc_platform_driver = {
    > .driver = {
    > .name = "rtc-m48t86",
    > + .of_match_table = of_match_ptr(m48t86_rtc_of_ids),
    > },
    > .probe = m48t86_rtc_probe,

    If you end up doing another revision, I'd suggest you drop the
    of_match_ptr() and the #ifdef: there is no point in saving a
    few bytes of space for non-DT kernel builds if both the machines
    that use this device always rquire CONFIG_OF to be enabled.

    Arnd

    \
     
     \ /
      Last update: 2023-04-24 11:48    [W:2.429 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site