Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Daniel Gomez <> | Subject | [PATCH] nvme: Increase block size variable size to 32-bit | Date | Tue, 30 May 2023 15:42:53 +0000 |
| |
Increase block size variable size to 32-bit unsigned to be able to support block devices larger than 32k (starting from 64 KiB).
Physical and logical block size already support unsigned 32-bit.
Signed-off-by: Daniel Gomez <da.gomez@samsung.com> ---
While experimenting and doing code inspection for large block devices, we found a limitation of a 32 KiB block size due to the bs variable type. With that limitation and in combination with a large block device, this results in a kernel BUG when the block layer attempts to split a block size of 0 bytes.
Increasing the value to 32-bit unsigned, allows to support large block devices starting from 64 KiB. In addition, this bs variable type aligns with the queue_limits logical/physical_block_size types.
drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 151b23400ada..b4bc48f2a011 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1835,7 +1835,7 @@ static void nvme_update_disk_info(struct gendisk *disk, struct nvme_ns *ns, struct nvme_id_ns *id) { sector_t capacity = nvme_lba_to_sect(ns, le64_to_cpu(id->nsze)); - unsigned short bs = 1 << ns->lba_shift; + u32 bs = 1 << ns->lba_shift; u32 atomic_bs, phys_bs, io_opt = 0;
/* -- 2.40.1
| ![\](/images/icornerr.gif) |