Messages in this thread Patch in this message | | | Subject | [PATCH] acpi: Fix header declaration of acpi_arch_dma_setup() w/o CONFIG_ACPI | From | Dave Jiang <> | Date | Mon, 22 May 2023 09:06:04 -0700 |
| |
arm64 build can be done without CONFIG_ACPI. The ifdef bits for acpi_arch_dma_setup() is placed inside CONFIG_ACPI. When CONFIG_ACPI is not set, this causes warning reported by kernel test bot. Move the prototype declaration for acpi_arch_dma_setup() outside of CONFIG_ACPI.
>> drivers/acpi/arm64/dma.c:7:6: warning: no previous prototype for function 'acpi_arch_dma_setup' [-Wmissing-prototypes] void acpi_arch_dma_setup(struct device *dev) ^ drivers/acpi/arm64/dma.c:7:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void acpi_arch_dma_setup(struct device *dev) ^ static 1 warning generated.
Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202305200933.afKCLlxS-lkp@intel.com/ Fixes: bf2ee8d0c385 ("ACPI: scan: Support multiple DMA windows with different offsets") CC: Jianmin Lv <lvjianmin@loongson.cn> CC: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Dave Jiang <dave.jiang@intel.com> --- include/linux/acpi.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 7b71dd74baeb..a0a8492d8a60 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -281,12 +281,6 @@ acpi_numa_processor_affinity_init(struct acpi_srat_cpu_affinity *pa) { } void acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa); -#if defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) -void acpi_arch_dma_setup(struct device *dev); -#else -static inline void acpi_arch_dma_setup(struct device *dev) { } -#endif - #ifdef CONFIG_ARM64 void acpi_numa_gicc_affinity_init(struct acpi_srat_gicc_affinity *pa); #else @@ -1084,6 +1078,12 @@ static inline bool acpi_sleep_state_supported(u8 sleep_state) #endif /* !CONFIG_ACPI */ +#if defined(CONFIG_ARM64) || defined(CONFIG_LOONGARCH) +void acpi_arch_dma_setup(struct device *dev); +#else +static inline void acpi_arch_dma_setup(struct device *dev) { } +#endif + #ifdef CONFIG_ACPI_HOTPLUG_IOAPIC int acpi_ioapic_add(acpi_handle root); #else
| |