Messages in this thread | | | Date | Wed, 8 Mar 2023 11:24:31 -0600 | From | Andrew Halaney <> | Subject | Re: [PATCH 0/4] serial: qcom-geni: fix console shutdown hang |
| |
On Tue, Mar 07, 2023 at 05:44:01PM +0100, Johan Hovold wrote: > This series fixes some of the fallout after a recent series adding > support for DMA transfers to the Qualcomm geni serial driver. > > Most importantly it fixes a hang during reboot when using a serial > console and the getty is stopped during reboot. > > Doug just posted an equivalent fix here: > > https://lore.kernel.org/lkml/20230307073155.1.Iaab0159b8d268060a0e131ebb27125af4750ef99@changeid > > but the commit message only mentions the regression with respect to > kgdb, which is not as widely used serial consoles generally, so I > figured I'd post my version for completeness. > > Either version of that fix should address the immediate regression, but > fixing the underlying problems which have been there since the driver > was first merged is going to be a bit more involved. > > The rest of the series fixes a few bugs in the new DMA support that I > found while investigating the console regression. > > Johan > > > Johan Hovold (4): > serial: qcom-geni: fix console shutdown hang > serial: qcom-geni: fix DMA mapping leak on shutdown > serial: qcom-geni: fix mapping of empty DMA buffer > serial: qcom-geni: drop bogus uart_write_wakeup() > > drivers/tty/serial/qcom_geni_serial.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > -- > 2.39.2 >
Realized this has been affecting me (with me blaming it on something else prior) off and on. Thanks for the fix!
Reviewed-by: Andrew Halaney <ahalaney@redhat.com> Tested-by: Andrew Halaney <ahalaney@redhat.com> # sa8540p-ride
| |