Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 7 Mar 2023 10:34:29 -0800 | Subject | Re: [PATCH 1/4] serial: qcom-geni: fix console shutdown hang |
| |
Hi,
On Tue, Mar 7, 2023 at 8:43 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > A recent commit added back the calls top stop tx and rx to shutdown() > which had previously been removed by commit e83766334f96 ("tty: serial: > qcom_geni_serial: No need to stop tx/rx on UART shutdown") in order to > be able to use kgdb after stopping the getty. > > Not only did this again break kgdb, but it also broke serial consoles > more generally by hanging TX when stopping the getty during reboot. > > The underlying problem has been there since the driver was first merged > and fixing it is going to be a bit involved so simply stop calling the > broken stop functions during shutdown for consoles for now. > > Fixes: d8aca2f96813 ("tty: serial: qcom-geni-serial: stop operations in progress at shutdown") > Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/tty/serial/qcom_geni_serial.c | 4 ++++ > 1 file changed, 4 insertions(+)
I'm fine with either this change or my change [1] landing.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
[1] https://lore.kernel.org/r/20230307073155.1.Iaab0159b8d268060a0e131ebb27125af4750ef99@changeid
| |