Messages in this thread | | | Date | Tue, 7 Mar 2023 16:32:04 +0000 | From | Gary Guo <> | Subject | Re: [PATCH] scripts: rust-analyzer: Skip crate module directories |
| |
On Tue, 7 Mar 2023 13:38:10 +0100 Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Tue, Mar 7, 2023 at 1:08 PM Andreas Hindborg <nmi@metaspace.dk> wrote: > > > > When generating rust-analyzer configuration, skip module directories. > > This is https://github.com/Rust-for-Linux/linux/pull/883, also handled > by Vinay's patch > https://lore.kernel.org/rust-for-linux/20230118160220.776302-1-varmavinaym@gmail.com/. > > Lina's approach is arguably a bit more idiomatic in Python in that it > is usually encouraged to follow the "Easier to ask for forgiveness > than permission" approach. > > Lina, would you like to submit yours? Or do you prefer a `Link: ` / > `Reported-by: ` / `Co-developed-by: ` here? > > > If `driver_mod` is a module of the crate `driver`, the directory `driver_mod` > > may not contain `Makefile`, and `generate_rust_analyzer.py` will fail. > > By the way, note that in the kernel crate we are avoiding `mod.rs` > files, instead using `name.rs` in the parent folder, in other to make > it easier to find the files. I will add a note about it in the docs.
I personally think mod.rs makes it easier for me to find files because all related stuff are contained inside a single directory, especially the parent modules and submodules are closed related.
That's just personal opinion though.
Best, Gary
| |