Messages in this thread | | | From | Andreas Hindborg <> | Subject | Re: [PATCH] scripts: rust-analyzer: Skip crate module directories | Date | Tue, 07 Mar 2023 13:53:53 +0100 |
| |
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:
> On Tue, Mar 7, 2023 at 1:08 PM Andreas Hindborg <nmi@metaspace.dk> wrote: >> >> When generating rust-analyzer configuration, skip module directories. > > This is https://github.com/Rust-for-Linux/linux/pull/883, also handled > by Vinay's patch > https://lore.kernel.org/rust-for-linux/20230118160220.776302-1-varmavinaym@gmail.com/.
Awesome, three solutions to the same problem 😅
> > Lina's approach is arguably a bit more idiomatic in Python in that it > is usually encouraged to follow the "Easier to ask for forgiveness > than permission" approach. > > Lina, would you like to submit yours? Or do you prefer a `Link: ` / > `Reported-by: ` / `Co-developed-by: ` here? > >> If `driver_mod` is a module of the crate `driver`, the directory `driver_mod` >> may not contain `Makefile`, and `generate_rust_analyzer.py` will fail. > > By the way, note that in the kernel crate we are avoiding `mod.rs` > files, instead using `name.rs` in the parent folder, in other to make > it easier to find the files. I will add a note about it in the docs.
Thanks for pointing that out :)
BR Andreas
| |