lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in
Date
> Linux has a lot of "static inline" functions. But that's not at all
> what that function was. It was literally just
>
> static void __resctrl_sched_in(..)
>
> which is disgusting and very wrong.

Ah. I was looking at:

static inline void resctrl_sched_in(void)
{
if (static_branch_likely(&rdt_enable_key))
__resctrl_sched_in();
}

which does have the "inline" attribute.

I wonder if checkpatch could catch missing "inline" on static
function definitions in header files?

-Tony
\
 
 \ /
  Last update: 2023-03-27 00:48    [W:0.107 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site