Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH] x86/resctrl: avoid compiler optimization in __resctrl_sched_in | Date | Tue, 7 Mar 2023 21:11:04 +0000 |
| |
> (a) it shouldn't define and declare a static function in a header file > > (b) the resctrl_sched_in() inline function is midesigned to begin with
Fixing "b" would seem to be to just pass "next_p" to the function to use instead of "current".
Can you expand about part "a" ... Linux has zillions of static inline functions in header files to handle CONFIG options. One version is the real McCoy while the other is just a stub for the CONFIG=n case.
What's different about this one?
-Tony
| |