Messages in this thread | | | From | Uwe Kleine-König <> | Subject | [PATCH 0/3] spmi: Convert to platform remove callback returning void | Date | Mon, 6 Mar 2023 08:34:43 +0100 |
| |
this patch series adapts the platform drivers below drivers/spmi to use the .remove_new() callback. Compared to the traditional .remove() callback .remove_new() returns no value. This is a good thing because the driver core doesn't (and cannot) cope for errors during remove. The only effect of a non-zero return value in .remove() is that the driver core emits a warning. The device is removed anyhow and an early return from .remove() usually yields a resource leak.
By changing the remove callback to return void driver authors cannot reasonably assume any more that there is some kind of cleanup later.
All drivers in drivers/spmi returned zero unconditionally in their remove callback, so they could all be converted trivially to .remove_new().
Note that this series depends on commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") which is included in v6.3-rc1.
Best regards Uwe
Uwe Kleine-König (3): spmi: hisi-spmi-controller: Convert to platform remove callback returning void spmi: mtk-pmif: Convert to platform remove callback returning void spmi: pmic-arb: Convert to platform remove callback returning void
drivers/spmi/hisi-spmi-controller.c | 5 ++--- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 -- 2.39.1
| |