Messages in this thread Patch in this message | | | From | Nur Hussein <> | Subject | [PATCH] Error checking for spi_setup during probe function added to rtc-m41t94 driver | Date | Sat, 4 Mar 2023 05:45:26 +0800 |
| |
The m41t94_probe() function calls spi_setup() but does not check for an error upon return. I have added this check, and returns the error and sets the error message via dev_error to "spi_setup failed".
Signed-off-by: Nur Hussein <hussein@unixcat.org> --- drivers/rtc/rtc-m41t94.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-m41t94.c b/drivers/rtc/rtc-m41t94.c index 6803b0273302..4bdee2336228 100644 --- a/drivers/rtc/rtc-m41t94.c +++ b/drivers/rtc/rtc-m41t94.c @@ -112,7 +112,12 @@ static int m41t94_probe(struct spi_device *spi) int res; spi->bits_per_word = 8; - spi_setup(spi); + + res = spi_setup(spi); + if (res < 0) { + dev_err(&spi->dev, "spi setup failed.\n"); + return res; + } res = spi_w8r8(spi, M41T94_REG_SECONDS); if (res < 0) { -- 2.34.1
| |