Messages in this thread | | | Date | Wed, 29 Mar 2023 13:06:09 +0800 | Subject | Re: Re: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object | From | Jia Zhu <> |
| |
在 2023/3/28 21:58, David Howells 写道: > Jia Zhu <zhujia.zj@bytedance.com> wrote: > >> @@ -65,10 +71,7 @@ struct cachefiles_object { >> enum cachefiles_content content_info:8; /* Info about content presence */ >> unsigned long flags; >> #define CACHEFILES_OBJECT_USING_TMPFILE 0 /* Have an unlinked tmpfile */ >> -#ifdef CONFIG_CACHEFILES_ONDEMAND >> - int ondemand_id; >> - enum cachefiles_object_state state; >> -#endif >> + struct cachefiles_ondemand_info *private; > > Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"? >
I'll revise it in next version.
> Also, please don't call it "private", but rather something like "ondemand" or > "ondemand_info".
I'll use @ondemand to replace it. Thanks. > > David >
| |