lkml.org 
[lkml]   [2023]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V4 2/5] cachefiles: extract ondemand info field from cachefiles_object
Date
Jia Zhu <zhujia.zj@bytedance.com> wrote:

> @@ -65,10 +71,7 @@ struct cachefiles_object {
> enum cachefiles_content content_info:8; /* Info about content presence */
> unsigned long flags;
> #define CACHEFILES_OBJECT_USING_TMPFILE 0 /* Have an unlinked tmpfile */
> -#ifdef CONFIG_CACHEFILES_ONDEMAND
> - int ondemand_id;
> - enum cachefiles_object_state state;
> -#endif
> + struct cachefiles_ondemand_info *private;

Why is this no longer inside "#ifdef CONFIG_CACHEFILES_ONDEMAND"?

Also, please don't call it "private", but rather something like "ondemand" or
"ondemand_info".

David

\
 
 \ /
  Last update: 2023-03-28 16:00    [W:0.124 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site