lkml.org 
[lkml]   [2023]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/5] arm64: dts: qcom: msm8916-thwc-ufi001c: add function to pin config
From


On 24.03.2023 21:22, Krzysztof Kozlowski wrote:
> Bindings require pin configuration nodes to have the function, even if
> it is GPIO:
>
> msm8916-thwc-ufi001c.dtb: pinctrl@1000000: sim-ctrl-default-state: 'oneOf' conditional failed, one must be fixed:
> 'esim-sel-pins', 'sim-en-pins', 'sim-sel-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
> index 8433c9710b1c..978f0abcdf8f 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-thwc-ufi001c.dts
> @@ -44,18 +44,21 @@ &msmgpio {
> sim_ctrl_default: sim-ctrl-default-state {
> esim-sel-pins {
> pins = "gpio0", "gpio3";
> + function = "gpio";
> bias-disable;
> output-low;
> };
>
> sim-en-pins {
> pins = "gpio1";
> + function = "gpio";
> bias-disable;
> output-low;
> };
>
> sim-sel-pins {
> pins = "gpio2";
> + function = "gpio";
> bias-disable;
> output-high;
> };

\
 
 \ /
  Last update: 2023-03-27 01:17    [W:0.122 / U:1.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site