Messages in this thread | | | Date | Thu, 23 Mar 2023 17:13:33 +0100 | From | Simon Horman <> | Subject | Re: [PATCH net-next 8/9] net: dsa: update TX path comments to not mention skb_mac_header() |
| |
On Thu, Mar 23, 2023 at 01:38:22AM +0200, Vladimir Oltean wrote: > Once commit 6d1ccff62780 ("net: reset mac header in dev_start_xmit()") > will be reverted, it will no longer be true that skb->data points at > skb_mac_header(skb) - since the skb->mac_header will not be set - so > stop saying that, and just say that it points to the MAC header. > > I've reviewed vlan_insert_tag() and it does not *actually* depend on > skb_mac_header(), so reword that to avoid the confusion. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
| |