Messages in this thread | | | Date | Thu, 23 Mar 2023 09:30:45 -0700 | Subject | Re: [PATCH net-next 1/9] net: vlan: don't adjust MAC header in __vlan_insert_inner_tag() unless set | From | Florian Fainelli <> |
| |
On 3/22/23 16:38, Vladimir Oltean wrote: > This is a preparatory change for the deletion of skb_reset_mac_header(skb) > from __dev_queue_xmit(). After that deletion, skb_mac_header(skb) will > no longer be set in TX paths, from which __vlan_insert_inner_tag() can > still be called (perhaps indirectly). > > If we don't make this change, then an unset MAC header (equal to ~0U) > will become set after the adjustment with VLAN_HLEN. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |