Messages in this thread | | | Date | Tue, 21 Mar 2023 18:31:22 +0100 | Subject | Re: [PATCH V1 1/4] dt-bindings: sram: qcom,imem: Add Boot Stat region within IMEM | From | Krzysztof Kozlowski <> |
| |
On 21/03/2023 14:51, Souradeep Chowdhury wrote: > All Qualcomm bootloaders log useful timestamp information related > to bootloader stats in the IMEM region. Add the child node within > IMEM for the boot stat region containing register address and > compatible string. > > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com> > --- > .../devicetree/bindings/sram/qcom,imem.yaml | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml > index 665c06e..c8c3890 100644 > --- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml > +++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml > @@ -48,6 +48,26 @@ patternProperties: > $ref: /schemas/remoteproc/qcom,pil-info.yaml# > description: Peripheral image loader relocation region > > + "^boot-stat@[0-9a-f]+$": > + type: object > + description: > + node for boot stat.
This basically copies the name of node, so not really helpful. Describe what's this.
> +
additionalProperties: false
> + properties: > + compatible: > + items:
Drop items.
> + - const: qcom,imem-boot_stats
No underscores in compatibles. Why this is not SoC specific compatible?
> + > + reg: > + maxItems: 1 > + description: > + The base address of the register region in case of > + imem boot stats.
Drop description, it's obvious. > + > + required: > + - compatible > + - reg > + Best regards, Krzysztof
| |