Messages in this thread | | | Date | Wed, 22 Mar 2023 17:29:51 +0100 | Subject | Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema | From | Krzysztof Kozlowski <> |
| |
On 22/03/2023 14:46, Souradeep Chowdhury wrote: >>> + - const: qcom,mpm2-sleep-counter >> >> SoC specific compatible. >> > > This is a generic Module Power Manager Sleep Counter which is present in > all Qcom Socs, so SoC specific compatible is not given here.
Not really a good reason and it is actually very difficult to verify this. If I understand correctly any moment FW can change and this will stop being valid, so no.
> >>> + >>> + reg: >>> + items: >>> + - description: MPM Sleep Counter Base >> >> just maxItems: 1 >> > > Ack >>> + >>> + clock-frequency: >>> + description: Frequency for the sleep counter >> >> Since this does not have clocks, what frequency you are setting here? > > Module Power Manager(MPM) Sleep Counter is a clock that starts ticking > from Primary Boot Loader(PBL) Stage. This is usually a 32 Khz clock and > the frequency for the same is stored here.
You just said all devices have the same MPM, so I would argue that all devices have the same clock.
Anyway, this is a legacy property.
Best regards, Krzysztof
| |