Messages in this thread | | | Date | Thu, 2 Mar 2023 14:31:14 +0100 | Subject | Re: [PATCH 1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml | From | Krzysztof Kozlowski <> |
| |
On 02/03/2023 12:55, richard.leitner@linux.dev wrote: > From: Richard Leitner <richard.leitner@skidata.com> > > Convert from max9867.txt to maxim,max9867.yaml and add missing > '#sound-dai-cells' property.
Thank you for your patch. There is something to discuss/improve.
Except wrong ID (and missing test):
> + > +examples: > + - | > + &i2c { > + max9867: max9867@18 {
Generic node names, so "codec" and drop the unused label.
Use 4 spaces for example indentation.
> + compatible = "maxim,max9867"; > + #sound-dai-cells = <0>; > + reg = <0x18>;
Best regards, Krzysztof
| |