lkml.org 
[lkml]   [2023]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support
On Thu, Mar 02, 2023 at 12:55:03PM +0100, richard.leitner@linux.dev wrote:

> + max9867->mclk = devm_clk_get(&i2c->dev, "mclk");
> + if (IS_ERR(max9867->mclk))
> + return PTR_ERR(max9867->mclk);
> + ret = clk_prepare_enable(max9867->mclk);
> + if (ret < 0)
> + dev_err(&i2c->dev, "Failed to enable MCLK: %d\n", ret);
> +

Nothing ever disables the clock - we need a disable in the remove path
at least.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-03-27 00:41    [W:0.091 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site