Messages in this thread | | | From | Jiasheng Jiang <> | Subject | Re: Re: [PATCH] octeontx2-vf: Add missing free for alloc_percpu | Date | Thu, 16 Mar 2023 17:58:20 +0800 |
| |
On Thu, Mar 16, 2023 at 10:39:11AM +0800, Jiasheng Jiang wrote: > On Thu, Mar 16, 2023 at 10:39:11AM +0800, Jiasheng Jiang wrote: >> Add the free_percpu for the allocated "vf->hw.lmt_info" in order to avoid >> memory leak, same as the "pf->hw.lmt_info" in >> `drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c`. >> >> Fixes: 5c0512072f65 ("octeontx2-pf: cn10k: Use runtime allocated LMTLINE region") >> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> >> --- >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c >> index 7f8ffbf79cf7..9db2e2d218bb 100644 >> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c >> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_vf.c >> @@ -709,6 +709,8 @@ static int otx2vf_probe(struct pci_dev *pdev, const struct pci_device_id *id) >> err_ptp_destroy: >> otx2_ptp_destroy(vf); >> err_detach_rsrc: >> + if (vf->hw.lmt_info) >> + free_percpu(vf->hw.lmt_info); >> if (test_bit(CN10K_LMTST, &vf->hw.cap_flag)) >> qmem_free(vf->dev, vf->dync_lmt); > I wonder if it wouldn't be more error prune when You create a function > to unroll cn10k_lmtst_init() like cn10k_lmtst_deinit(). These two if can > be there, maybe also sth else is missing. > > Otherwise it is fine > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
I try my best and find nothing else missing.
Thanks, Jiang
| |