Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 15 Mar 2023 17:11:22 +0000 | From | Lee Jones <> | Subject | Re: [PATCH RESEND] leds: qcom-lpg: Release node reference before returning |
| |
On Sat, 04 Mar 2023, Deepak R Varma wrote:
> The iterator for_each_available_child_of_node() increments the refcount > of the child node it is processing. Release such a reference when the > loop needs to breaks due to en error during its execution. > Issue identified using for_each_child.cocci Coccinelle semantic patch. > > Signed-off-by: Deepak R Varma <drv@mailo.com> > --- > Please note: > - The proposed change is compile tested only. I do not have the > necessary hardware to perform additional testing. Please suggest if there > is an alternate means available to further test this change. > - Included authors/experts for this driver for guidance as suggested by > Lee Jones <lee@kernel.org> and resending the patch. > > > drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
-- Lee Jones [李琼斯]
| ![\](/images/icornerr.gif) |