Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 13 Mar 2023 10:43:44 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 2/5] clocksource: timer-stm32-lp: Mark driver as non-removable |
| |
Hello,
On Mon, Mar 13, 2023 at 08:54:27AM +0100, Uwe Kleine-König wrote: > The comment in the remove callback suggests that the driver is not > supposed to be unbound. However returning an error code in the remove > callback doesn't accomplish that. Instead set the suppress_bind_attrs > property (which makes it impossible to unbind the driver via sysfs). > The only remaining way to unbind an stm32-lp device would be module > unloading, but that doesn't apply here, as the driver cannot be built as > a module. > > Also drop the useless remove callback. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/clocksource/timer-stm32-lp.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/clocksource/timer-stm32-lp.c b/drivers/clocksource/timer-stm32-lp.c > index db2841d0beb8..616ea4fe4234 100644 > --- a/drivers/clocksource/timer-stm32-lp.c > +++ b/drivers/clocksource/timer-stm32-lp.c > @@ -195,11 +195,6 @@ static int stm32_clkevent_lp_probe(struct platform_device *pdev) > return ret; > } > > -static int stm32_clkevent_lp_remove(struct platform_device *pdev) > -{ > - return -EBUSY; /* cannot unregister clockevent */ > -} > - > static const struct of_device_id stm32_clkevent_lp_of_match[] = { > { .compatible = "st,stm32-lptimer-timer", }, > {}, > @@ -207,11 +202,11 @@ static const struct of_device_id stm32_clkevent_lp_of_match[] = { > MODULE_DEVICE_TABLE(of, stm32_clkevent_lp_of_match); > > static struct platform_driver stm32_clkevent_lp_driver = { > - .probe = stm32_clkevent_lp_probe, > .remove = stm32_clkevent_lp_remove,
This is of course broken, I intended to drop the remove line ... and only noticed that breakage after sending out the patch set :-\
So please either skip this patch, or fixup while applying. If you do the former I'll come back to this driver and send a fixed patch.
Best regards and sorry Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |