lkml.org 
[lkml]   [2023]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] clocksource: timer-ti-dm: Convert to platform remove callback returning void
    Date
    The .remove() callback for a platform driver returns an int which makes
    many driver authors wrongly assume it's possible to do error handling by
    returning an error code. However the value returned is (mostly) ignored
    and this typically results in resource leaks. To improve here there is a
    quest to make the remove callback return void. In the first step of this
    quest all drivers are converted to .remove_new() which already returns
    void.

    Trivially convert this driver from always returning zero in the remove
    callback to the void returning variant.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/clocksource/timer-ti-dm.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
    index 098562bda487..ab7a6caa36c5 100644
    --- a/drivers/clocksource/timer-ti-dm.c
    +++ b/drivers/clocksource/timer-ti-dm.c
    @@ -1177,7 +1177,7 @@ static int omap_dm_timer_probe(struct platform_device *pdev)
    * In addition to freeing platform resources it also deletes the timer
    * entry from the local list.
    */
    -static int omap_dm_timer_remove(struct platform_device *pdev)
    +static void omap_dm_timer_remove(struct platform_device *pdev)
    {
    struct dmtimer *timer;
    unsigned long flags;
    @@ -1199,8 +1199,6 @@ static int omap_dm_timer_remove(struct platform_device *pdev)

    if (ret)
    dev_err(&pdev->dev, "Unable to determine timer entry in list of drivers on remove\n");
    -
    - return 0;
    }

    static const struct omap_dm_timer_ops dmtimer_ops = {
    @@ -1275,7 +1273,7 @@ MODULE_DEVICE_TABLE(of, omap_timer_match);

    static struct platform_driver omap_dm_timer_driver = {
    .probe = omap_dm_timer_probe,
    - .remove = omap_dm_timer_remove,
    + .remove_new = omap_dm_timer_remove,
    .driver = {
    .name = "omap_timer",
    .of_match_table = omap_timer_match,
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-27 00:56    [W:3.172 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site