Messages in this thread Patch in this message | | | Date | Fri, 10 Mar 2023 10:32:35 +0100 | Subject | Re: [PATCH v1 3/3] cpufreq: mediatek: raise proc/sram max voltage for MT7622 and MT8516 | From | AngeloGioacchino Del Regno <> |
| |
Il 10/03/23 06:17, jia-wei.chang ha scritto: > From: "Jia-Wei Chang" <jia-wei.chang@mediatek.com> > > Since the upper boundary of proc/sram voltage of MT7622 and MT8516 are > 1350 mV and 1300 mV respectively, both are greater than the value of > MT2701 1150 mV, we fix it by adding the corresponding platform data and > specify proc/sram_max_volt to support MT7622 and MT8516 individually. > > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com> > Fixes: ead858bd128d ("cpufreq: mediatek: Move voltage limits to platform data") > Fixes: 6a17b3876bc8 ("cpufreq: mediatek: Refine mtk_cpufreq_voltage_tracking()") > Reported-by: Nick Hainke <vincent@systemli.org> > Link: https://lore.kernel.org/lkml/75216e0c-9d36-7ada-1507-1bb4a91a3326@systemli.org/T/
that's 2/3 my patch, 1/3 your patch..... ...in that case, send my patch as it is and add one more for MT8516.
Regards, Angelo
> --- > drivers/cpufreq/mediatek-cpufreq.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c > index cb8b76f9c2c3..f6824d4bf85d 100644 > --- a/drivers/cpufreq/mediatek-cpufreq.c > +++ b/drivers/cpufreq/mediatek-cpufreq.c > @@ -707,6 +707,15 @@ static const struct mtk_cpufreq_platform_data mt2701_platform_data = { > .ccifreq_supported = false, > }; > > +static const struct mtk_cpufreq_platform_data mt7622_platform_data = { > + .min_volt_shift = 100000, > + .max_volt_shift = 200000, > + .proc_max_volt = 1360000, > + .sram_min_volt = 0, > + .sram_max_volt = 1360000, > + .ccifreq_supported = false, > +}; > + > static const struct mtk_cpufreq_platform_data mt8183_platform_data = { > .min_volt_shift = 100000, > .max_volt_shift = 200000, > @@ -725,20 +734,29 @@ static const struct mtk_cpufreq_platform_data mt8186_platform_data = { > .ccifreq_supported = true, > }; > > +static const struct mtk_cpufreq_platform_data mt8516_platform_data = { > + .min_volt_shift = 100000, > + .max_volt_shift = 200000, > + .proc_max_volt = 1310000, > + .sram_min_volt = 0, > + .sram_max_volt = 1310000, > + .ccifreq_supported = false, > +}; > + > /* List of machines supported by this driver */ > static const struct of_device_id mtk_cpufreq_machines[] __initconst = { > { .compatible = "mediatek,mt2701", .data = &mt2701_platform_data }, > { .compatible = "mediatek,mt2712", .data = &mt2701_platform_data }, > - { .compatible = "mediatek,mt7622", .data = &mt2701_platform_data }, > - { .compatible = "mediatek,mt7623", .data = &mt2701_platform_data }, > - { .compatible = "mediatek,mt8167", .data = &mt2701_platform_data }, > + { .compatible = "mediatek,mt7622", .data = &mt7622_platform_data }, > + { .compatible = "mediatek,mt7623", .data = &mt7622_platform_data }, > + { .compatible = "mediatek,mt8167", .data = &mt8516_platform_data }, > { .compatible = "mediatek,mt817x", .data = &mt2701_platform_data }, > { .compatible = "mediatek,mt8173", .data = &mt2701_platform_data }, > { .compatible = "mediatek,mt8176", .data = &mt2701_platform_data }, > { .compatible = "mediatek,mt8183", .data = &mt8183_platform_data }, > { .compatible = "mediatek,mt8186", .data = &mt8186_platform_data }, > { .compatible = "mediatek,mt8365", .data = &mt2701_platform_data }, > - { .compatible = "mediatek,mt8516", .data = &mt2701_platform_data }, > + { .compatible = "mediatek,mt8516", .data = &mt8516_platform_data }, > { } > }; > MODULE_DEVICE_TABLE(of, mtk_cpufreq_machines);
| |