Messages in this thread | | | Date | Fri, 10 Mar 2023 18:41:00 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() |
| |
On Fri, 10 Mar 2023 21:17:06 +0100 Simon Horman wrote: > > > nit: I think < 80 columns wide is still preferred for network code > > > > I can do it if it's a strict rule here. > > I think it is more a preference than a strict rule at this point.
You're right, but the longer I think about it the more I feel like it should be.
80 chars is an artificial constraint these day but it simply results in more readable code.
I can't see the entirety of "hellcreek->led_sync_good.brightness" at once, using it as lval in 3 different places is not great. Maybe it's my poor eyesight.
| |