Messages in this thread | | | Date | Fri, 10 Mar 2023 22:06:00 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH net-next v5 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() |
| |
On Fri, Mar 10, 2023 at 08:44:05PM +0200, Andy Shevchenko wrote: > On Fri, Mar 10, 2023 at 07:18:42PM +0100, Simon Horman wrote: > > On Fri, Mar 10, 2023 at 06:38:55PM +0200, Andy Shevchenko wrote:
...
> > This seems to duplicate the logic in the earlier hunk of this patch. > > Could it be moved into a helper? > > It's possible, but in a separate patch as it's out of scope of this one. > Do you want to create a such?
FWIW, I tried and it gives us +9 lines of code. So, what would be the point? I can send as RFC in v6.
-- With Best Regards, Andy Shevchenko
| |