| Date | Sat, 18 Feb 2023 17:38:06 +0900 | From | asmadeus@codewrec ... | Subject | Re: [PATCH v4 10/11] fs/9p: writeback mode fixes |
| |
(not reviewed this yet, just a kerneldoc warning first before I forget)
Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 12:33:22AM +0000: > diff --git a/fs/9p/fid.c b/fs/9p/fid.c > index 805151114e96..8c1697619f3d 100644 > --- a/fs/9p/fid.c > +++ b/fs/9p/fid.c > @@ -41,14 +40,24 @@ void v9fs_fid_add(struct dentry *dentry, struct p9_fid **pfid) > *pfid = NULL; > } > > +static bool v9fs_is_writeable(int mode) > +{ > + if ((mode & P9_OWRITE) || (mode & P9_ORDWR)) > + return true; > + else > + return false; > +} > + > /** > * v9fs_fid_find_inode - search for an open fid off of the inode list > * @inode: return a fid pointing to a specific inode > + * @writeable: only consider fids which are writeable
`make M=fs/9p W=1` complains about doc discreptancy here, writeable vs. want_writeable.
These are a pain, but let's make sure new ones don't creep in... (I just wish we could make W=1 the default for part of the subtree, but I didn't find an easy way to do so last time I checked -- perhaps you'll have more luck if you have time to look)
> * @uid: return a fid belonging to the specified user > + * @any: ignore uid as a selection criteria > * > */ > - > -static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid) > +struct p9_fid *v9fs_fid_find_inode(struct inode *inode, bool want_writeable, > + kuid_t uid, bool any)
-- Dominique
|