Messages in this thread | | | Date | Sun, 19 Feb 2023 05:30:31 +0900 | From | asmadeus@codewrec ... | Subject | Re: [PATCH v4 04/11] fs/9p: Remove unnecessary superblock flags |
| |
Eric Van Hensbergen wrote on Sat, Feb 18, 2023 at 10:24:17AM -0600: > That's fair -- and it didn't seem to hurt anything to have DIRSYNC at > the moment, so I can drop this patch if we think its too much noise. > I guess it was more of a reaction the filesystem implicitly setting > mount flags which might override whatever the user intended. FWIW > SB_SYNCHRONOUS did seem to have an effect on behavior (although I > didn't specifically track down where) -- I noticed this because the > problems Christian found seemed to go away if I mounted the filesystem > with sync (which basically ended up overriding aspects of the cache > configuration I guess).
I guess it doesn't hurt either way; happy to keep this patch in doubt.
-- Dominique
| |