Messages in this thread | | | Date | Thu, 14 Dec 2023 16:53:34 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/5] gpiolib: cdev: adopt scoped_guard() |
| |
On Thu, Dec 14, 2023 at 05:58:10PM +0800, Kent Gibson wrote: > Use scoped_guard for critical sections rather than distinct
scoped_guard()
> lock/unlock pairs.
...
> - mutex_lock(&lr->config_mutex); > - > - ret = linereq_set_values_unlocked(lr, &lv); > - > - mutex_unlock(&lr->config_mutex); > + scoped_guard(mutex, &lr->config_mutex) > + ret = linereq_set_values_unlocked(lr, &lv); > > return ret;
In this case it can be guard()
guard(...)(...);
return linereq_...
...
> - mutex_lock(&lr->config_mutex); > - > - ret = linereq_set_config_unlocked(lr, &lc); > - > - mutex_unlock(&lr->config_mutex); > + scoped_guard(mutex, &lr->config_mutex) > + ret = linereq_set_config_unlocked(lr, &lc); > > return ret;
Ditto.
-- With Best Regards, Andy Shevchenko
| |