Messages in this thread | | | Date | Thu, 14 Dec 2023 17:27:56 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 5/5] gpiolib: cdev: improve documentation of get/set values |
| |
On Thu, Dec 14, 2023 at 11:23:01PM +0800, Kent Gibson wrote: > On Thu, Dec 14, 2023 at 05:12:36PM +0200, Andy Shevchenko wrote: > > On Thu, Dec 14, 2023 at 05:58:14PM +0800, Kent Gibson wrote: > > > Add documentation of the algorithm used to perform scatter/gather > > > of the requested lines and values in linereq_get_values() and > > > linereq_set_values_unlocked() to improve maintainability. > > > > I believe this is based on the old discussion in the thread where I proposed > > the patch to convert this (unreadable in my opinion) code to use bitmap APIs. > > I believe you are correct - that the code is unreadable in your > opinion. And I noted that you were the origin of this change in the > cover letter. > > I'm not usually comforable with this level of hand holding, but I made > an exception in your case.
At least it helps somebody to understand that, thank you!
-- With Best Regards, Andy Shevchenko
| |