Messages in this thread Patch in this message | | | Date | Mon, 9 Oct 2023 11:39:15 -0700 | Subject | [PATCH v3 13/18] perf lock: Fix a memory leak on an error path | From | Ian Rogers <> |
| |
If a memory allocation fails then the strdup-ed string needs freeing. Detected by clang-tidy.
Signed-off-by: Ian Rogers <irogers@google.com> --- tools/perf/builtin-lock.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c index fa7419978353..a3ff2f4edbaa 100644 --- a/tools/perf/builtin-lock.c +++ b/tools/perf/builtin-lock.c @@ -2478,6 +2478,7 @@ static int parse_call_stack(const struct option *opt __maybe_unused, const char entry = malloc(sizeof(*entry) + strlen(tok) + 1); if (entry == NULL) { pr_err("Memory allocation failure\n"); + free(s); return -1; } -- 2.42.0.609.gbb76f46606-goog
| |