lkml.org 
[lkml]   [2023]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH v3 08/18] perf mem-events: Avoid uninitialized read
    From
    pmu should be initialized to NULL before perf_pmus__scan loop. Fix and
    shrink the scope of pmu at the same time. Issue detected by clang-tidy.

    Fixes: 5752c20f3787 ("perf mem: Scan all PMUs instead of just core ones")
    Signed-off-by: Ian Rogers <irogers@google.com>
    ---
    tools/perf/util/mem-events.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
    index 39ffe8ceb380..954b235e12e5 100644
    --- a/tools/perf/util/mem-events.c
    +++ b/tools/perf/util/mem-events.c
    @@ -185,7 +185,6 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr,
    {
    int i = *argv_nr, k = 0;
    struct perf_mem_event *e;
    - struct perf_pmu *pmu;

    for (int j = 0; j < PERF_MEM_EVENTS__MAX; j++) {
    e = perf_mem_events__ptr(j);
    @@ -202,6 +201,8 @@ int perf_mem_events__record_args(const char **rec_argv, int *argv_nr,
    rec_argv[i++] = "-e";
    rec_argv[i++] = perf_mem_events__name(j, NULL);
    } else {
    + struct perf_pmu *pmu = NULL;
    +
    if (!e->supported) {
    perf_mem_events__print_unsupport_hybrid(e, j);
    return -1;
    --
    2.42.0.609.gbb76f46606-goog
    \
     
     \ /
      Last update: 2023-10-09 20:40    [W:2.748 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site