Messages in this thread | | | Date | Tue, 3 Oct 2023 14:20:11 -0700 | Subject | Re: [PATCH v6 20/24] x86/resctrl: Add CPU online callback for resctrl work | From | Reinette Chatre <> |
| |
Hi James,
On 9/14/2023 10:21 AM, James Morse wrote: > The resctrl architecture specific code may need to create a domain when > a CPU comes online, it also needs to reset the CPUs PQR_ASSOC register. > The resctrl filesystem code needs to update the rdtgroup_default CPU > mask when CPUs are brought online. > > Currently this is all done in one function, resctrl_online_cpu(). > This will need to be split into architecture and filesystem parts > before resctrl can be moved to /fs/. > > Pull the rdtgroup_default update work out as a filesystem specific > cpu_online helper. resctrl_online_cpu() is the obvious name for this, > which means the version in core.c needs renaming. > > resctrl_online_cpu() is called by the arch code once it has done the > work to add the new CPU to any domains. > > In future patches, resctrl_online_cpu() will take the rdtgroup_mutex > itself. > > Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Tested-By: Peter Newman <peternewman@google.com> > Signed-off-by: James Morse <james.morse@arm.com> > ---
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |