lkml.org 
[lkml]   [2023]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6 02/24] x86/resctrl: kfree() rmid_ptrs from rdtgroup_exit()
    From
    Hi James,

    On 9/14/2023 10:21 AM, James Morse wrote:

    ...

    > diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
    > index 725344048f85..a2158c266e41 100644
    > --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
    > +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
    > @@ -3867,6 +3867,11 @@ int __init rdtgroup_init(void)
    >
    > void __exit rdtgroup_exit(void)
    > {
    > + struct rdt_resource *r = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl;
    > +
    > + if (r->mon_capable)
    > + resctrl_exit_mon_l3_config(r);
    > +
    > debugfs_remove_recursive(debugfs_resctrl);
    > unregister_filesystem(&rdt_fs_type);
    > sysfs_remove_mount_point(fs_kobj, "resctrl");

    You did not respond to me when I requested that this be done differently [1].
    Without a response letting me know the faults of my proposal or following the
    recommendation I conclude that my feedback was ignored.

    Reinette

    [1] https://lore.kernel.org/lkml/1ccd6be5-1dbd-c4a5-659f-ae20761dcce7@intel.com/

    \
     
     \ /
      Last update: 2023-10-02 19:01    [W:2.403 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site