Messages in this thread | | | Date | Fri, 27 Oct 2023 14:07:41 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor |
| |
On Fri, Oct 27, 2023 at 06:15:45PM +1030, Subhajit Ghosh wrote: > Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor with als > and clear channels with i2c interface. Hardware interrupt configuration is > optional. It is a low power device with 20 bit resolution and has > configurable adaptive interrupt mode and interrupt persistence mode. > The device also features inbuilt hardware gain, multiple integration time > selection options and sampling frequency selection options.
Please, do not send so often this big patches (~1.5kLoC!), let reviewers a bit of time, please.
Since I have my message postponed, I finish review on the v1, and I believe 100% of those comments will be applicable here.
-- With Best Regards, Andy Shevchenko
| |