Messages in this thread | | | Date | Fri, 27 Oct 2023 19:12:59 +1030 | Subject | Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor | From | Subhajit Ghosh <> |
| |
On 27/10/23 18:43, Krzysztof Kozlowski wrote: > On 27/10/2023 09:45, Subhajit Ghosh wrote: >> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor with als >> and clear channels with i2c interface. Hardware interrupt configuration is >> optional. It is a low power device with 20 bit resolution and has >> configurable adaptive interrupt mode and interrupt persistence mode. >> The device also features inbuilt hardware gain, multiple integration time >> selection options and sampling frequency selection options. >> >> v1 -> v2 >> - Renamed probe_new to probe >> - Removed module id table > > This is fourth version of this patchset, not second, so v4. > > Best regards, > Krzysztof > Hi Krzysztof,
1. This patch set adds support for APDS9306 Light sensor, 2. In v0 of this patch series I was told to combine the avago,apds9300.yaml and avago,apds9960.yaml as they look similar, then add my apds9306 support into it. 3. I assumed that the squashing operation of apds9300 and apds9960 schemas are a separate operation and submitted a separate patch to do that, please follow the link Link: https://lore.kernel.org/all/20231019-hurry-eagle-0ffa95b1a026@spud/ 4. Conor reviewed the patch and said that it would be better that I handle all these operations in apds9306 driver (this) patch series rather than submitting a new patch. "Ahh apologies then. The best course of action would likely be to include the patch merging the two bindings in your series adding the third user." 5. As per this patch series -- RFC->v0->v1-v2
I have formatted the commit messages wrongly which might be the source of all the confusion. I'll fix it. Please let me know the best course of action, I am not well versed with this process. Thank you for reviewing.
Regards, Subhajit Ghosh
| |