Messages in this thread Patch in this message | | | Date | Thu, 26 Oct 2023 16:47:23 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile |
| |
Em Mon, Oct 23, 2023 at 03:31:44AM +0000, Yang Jihong escreveu: > evsel__increase_rlimit() helper does nothing with evsel, and description > of the functionality is inaccurate, rename it and move to util/rlimit.c. > By the way, fix a checkppatch warning about misplaced license tag: > WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead > #160: FILE: tools/perf/util/rlimit.h:3: > /* SPDX-License-Identifier: LGPL-2.1 */ > No functional change.
Please run 'perf test' before sending patches upstream, I'm checking if what is in perf-tools-next/perf-tools-next is building and I noticed this:
⬢[acme@toolbox perf-tools-next]$ perf test -v python Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc 14: 'import perf' in python : --- start --- test child forked, pid 2912462 python usage test: "echo "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" | '/usr/bin/python3' " Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /tmp/build/perf-tools-next/python/perf.cpython-311-x86_64-linux-gnu.so: undefined symbol: rlimit__increase_nofile test child finished with -1 ---- end ---- 'import perf' in python: FAILED! ⬢[acme@toolbox perf-tools-next]$
The following patch cures it, Namhyung, can you please fold it and force push perf-tools-next/perf-tools-next or let me know if you prefer that I submit a patch fixing this separately.
- Arnaldo
diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources index 26e1c8d973ea0b95..593b660ec75e24e1 100644 --- a/tools/perf/util/python-ext-sources +++ b/tools/perf/util/python-ext-sources @@ -40,6 +40,7 @@ util/rwsem.c util/hashmap.c util/perf_regs.c util/fncache.c +util/rlimit.c util/perf-regs-arch/perf_regs_aarch64.c util/perf-regs-arch/perf_regs_arm.c util/perf-regs-arch/perf_regs_csky.c
| |