lkml.org 
[lkml]   [2023]   [Oct]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] perf evsel: Rename evsel__increase_rlimit to rlimit__increase_nofile
From
Date
Hello,

On 2023/10/27 6:08, Namhyung Kim wrote:
> Hi Arnaldo,
>
> On Thu, Oct 26, 2023 at 12:47 PM Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
>>
>> Em Mon, Oct 23, 2023 at 03:31:44AM +0000, Yang Jihong escreveu:
>>> evsel__increase_rlimit() helper does nothing with evsel, and description
>>> of the functionality is inaccurate, rename it and move to util/rlimit.c.
>>
>>> By the way, fix a checkppatch warning about misplaced license tag:
>>
>>> WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead
>>> #160: FILE: tools/perf/util/rlimit.h:3:
>>> /* SPDX-License-Identifier: LGPL-2.1 */
>>
>>> No functional change.
>>
>> Please run 'perf test' before sending patches upstream, I'm checking if
>> what is in perf-tools-next/perf-tools-next is building and I noticed
>> this:
>>
>> ⬢[acme@toolbox perf-tools-next]$ perf test -v python
>> Couldn't bump rlimit(MEMLOCK), failures may take place when creating BPF maps, etc
>> 14: 'import perf' in python :
>> --- start ---
>> test child forked, pid 2912462
>> python usage test: "echo "import sys ; sys.path.insert(0, '/tmp/build/perf-tools-next/python'); import perf" | '/usr/bin/python3' "
>> Traceback (most recent call last):
>> File "<stdin>", line 1, in <module>
>> ImportError: /tmp/build/perf-tools-next/python/perf.cpython-311-x86_64-linux-gnu.so: undefined symbol: rlimit__increase_nofile
>> test child finished with -1
>> ---- end ----
>> 'import perf' in python: FAILED!
>> ⬢[acme@toolbox perf-tools-next]$
>>
>> The following patch cures it, Namhyung, can you please fold it and force
>> push perf-tools-next/perf-tools-next or let me know if you prefer that I
>> submit a patch fixing this separately.
>
> Thanks for fixing this. I prefer having a separate fix.
> Please send it as a formal patch.
>

Sorry, only rename helper and no function change.
I didn't consider the scenario that might affect test python.

I've submitted a fix that can be used if needed:

https://lore.kernel.org/lkml/20231027023028.1106441-1-yangjihong1@huawei.com/

Also, can we consider identifying this problem at the stage of compiling
the perf tool?


Thanks,
Yang

\
 
 \ /
  Last update: 2023-10-27 08:48    [W:0.160 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site